lexibank / abvdoceanic

Creative Commons Attribution 4.0 International
5 stars 2 forks source link

Malekula transcriptions incorrect - correct by modifying per-language profiles #30

Closed antipodite closed 2 years ago

antipodite commented 2 years ago

Making this issue cf. our email chain.

I just tested Timo's updated profile for Neverver (Lingarak - Sakan), copying changes into the source column and re-running cldfbench lexibank.makecldf. Now cldfbench abvdoceanic.inventories gives us 7 vowels and 21 consonants, down from 14 V and 34 C. Does this look correct? If so we can get started tomorrow on the rest of the profiles. Can't assign Timo is he on this repo?

maryewal commented 2 years ago

Thanks @antipodite. I think that is much more reasonable sounding! I also had toruble assigning Timo here. Perhaps he needs to be added as a collaborator @LinguList? His user name is @tihomirrangelov.

tihomirrangelov commented 2 years ago

7 vowels and 21 consonants is definitely much closer to the truth.

antipodite commented 2 years ago

Pushed all Timo's edited profiles into the master orthoprofile dir

maryewal commented 2 years ago

@tihomirrangelov and I discussed yesterday and he will go through the rest of these starting next week. He'll make the edits directly in the repo and flag any concerns/questions as issues [Orthography-Malekula].

antipodite commented 2 years ago

Cool, @tihomirrangelov make a branch so you can do the pull request:

cd abvdoceanic
git branch profiles
git checkout profiles

Then when you've git pushed your changes, go to https://github.com/lexibank/abvdoceanic/pulls and click "Create pull request" for your profiles branch.