search

lexibank / abvdoceanic

Creative Commons Attribution 4.0 International
5 stars 2 forks source link

first_form_only is wrong #35

Open SimonGreenhill opened 2 years ago

SimonGreenhill commented 2 years ago

There should not be any combined forms, if there are commas then these will be in proto-forms e.g. ("CVC(x,y)") or should be fixed upstream

https://github.com/lexibank/abvdoceanic/blob/0229c3a7ea4d84c0aa19d468391ea62b478de856/lexibank_abvdoceanic.py#L43

LinguList commented 2 years ago

So should we pull out the list where this applies?

SimonGreenhill commented 2 years ago

yeah, then I can fix them :)

LinguList commented 2 years ago

Okay. I'd add this as a blacklist then (etc/lexemes.tsv).

SimonGreenhill commented 2 years ago

give me 10m to push through an interim data update so we have the most updated data here to work off..

SimonGreenhill commented 2 years ago

oh and please keep the lexeme id in the blacklist so I can easily find it in ABVD :)

LinguList commented 2 years ago

Sure :)

SimonGreenhill commented 2 years ago

Cool -- update here: https://github.com/lexibank/abvdoceanic/commit/06d7099e1317e563a2dba4259a5226ff7c7fbe63 (pushed to main, oops, sorry)

LinguList commented 2 years ago

No problem at all!