search

lexibank / abvdoceanic

Creative Commons Attribution 4.0 International
5 stars 2 forks source link

fix consonant clusters #52

Closed FredericBlum closed 1 month ago

FredericBlum commented 1 month ago

I have added some fixes which address #50 .

I tried to keep the impact as minimal as possible, by adding as much phonological context as possible. I have also focused on the clusters that seemed most drastic (C>4). With the added changes, I think we could start the release. But it would be great if you could double-check on the changes and their implications @tihomirrangelov . I have also tagged @SimonGreenhill and @antipodite to have more eyes.

FredericBlum commented 1 month ago

@SimonGreenhill I got approval from @tihomirrangelov . If you also agree, I can merge this and release a v0.3

SimonGreenhill commented 1 month ago

Awesome, thanks for your help with this @tihomirrangelov !

SimonGreenhill commented 1 month ago

@FredericBlum -- can you add Timo's changes to the main abvd lexibank https://github.com/lexibank/abvd dataset too please? the languages are the same (as for the abvd_philippines)

FredericBlum commented 1 month ago

The CLTS-mapping over there seems to work differently, since there is no orthography profile file. So I don't think adding the changes is possible. I'll have to leave that to the ABVD team I guess.