search

lexibank / allenbai

CLDF dataset derived from Allen's "Bai Dialect Survey" from 2007
Creative Commons Attribution 4.0 International
0 stars 0 forks source link

refactored according to the proposal in lexibank/pylexibank#19 #3

Closed xrotwang closed 6 years ago

xrotwang commented 6 years ago

Don't merge this yet. This is just a demonstrator for possible changes.

xrotwang commented 6 years ago

Overall, I think it makes sense to change the API as proposed, adding add_concepts and add_languages methods to the CLDF dataset class. It shaves off a couple lines of custom code and is still transparent enough: https://github.com/lexibank/allenbai/pull/3/files#diff-bfcd516cfb05c3cf3e23114a2bfebd78

LinguList commented 6 years ago

Saving these lines of code is very good indeed.

xrotwang commented 6 years ago

@LinguList yes, the concept list is in Concepticon, and that's where the data for parameters.csv is fetched. add_concepts will add concepts from the associated concept list in Concepticon, and if none is declared, add the concepts from etc/concepts.csv.

LinguList commented 6 years ago

Ah, okay, so this is just a fall-back. Then it's all fine with this version!

xrotwang commented 6 years ago

Ok, I'll finish up the code in pylexibank, make a release, then update the dependency in setup.py and release the datasets :)

SimonGreenhill commented 6 years ago

I like this too! Nice!