search

lexibank / pylexibank

The python curation library for lexibank
Apache License 2.0
18 stars 7 forks source link

Should "lexibank.check" raise an Exception if any warnings are issued? #181

Closed xrotwang closed 4 years ago

xrotwang commented 4 years ago

I think it would be easier to integrate cldfbench lexibank.check with cldf-buildbot if it returned a non-zero exit status, e.g. by raising an exception, if any warnings have been issued during the checks.

xrotwang commented 4 years ago

Ah, just learned that buildbot has a result code WARNINGS and that we can easily set that via a ShellCommands decodeRC argument.

So, I'd propose to return 2 from lexibank.check in case any warnings have been issued.

xrotwang commented 4 years ago

It may still become a bit of a problem, if many datasets trigger warnings about things that cannot be fixed, e.g. about bookkeeping languoids with no alternative. But I guess, we'll have to see how this pans out in practice.

xrotwang commented 4 years ago

I like it!

Screenshot_2020-03-06 Buildbot Screenshot_2020-03-06 Buildbot builder lexibank-chenhmongmien build 2

SimonGreenhill commented 4 years ago

Oh that’s cool. Everything done in 2m or so. This is going to be really helpful!

xrotwang commented 4 years ago

Looking forward to seeing this with >100 datasets on the server :)

xrotwang commented 4 years ago

And I think at ~100 lines of config, that's still fairly maintainable.

SimonGreenhill commented 4 years ago

Just need to make sure we have lots of cores and we can just spawn a worker per dataset :)

xrotwang commented 4 years ago

Hitting "build all" in the evening and fixing warnings during the day is probably ok, too, to push out a release within a couple of days :)