search

lexibank / pylexibank

The python curation library for lexibank
Apache License 2.0
18 stars 7 forks source link

adding table name to empty check #191

Closed SimonGreenhill closed 4 years ago

SimonGreenhill commented 4 years ago

fixes #190

xrotwang commented 4 years ago

Not really related to this - but I a leftover I forgot to remove when cleaning up checks: This https://github.com/lexibank/pylexibank/blob/674cdd0de1083cbffdea331fd90b66064d1d42de/src/pylexibank/commands/check_lexibank.py#L24-L27 could be removed.

SimonGreenhill commented 4 years ago

I’ll make a PR to remove shortly.

On 13/03/2020, at 18:04, Robert Forkel notifications@github.com wrote:

 Not really related to this - but I a leftover I forgot to remove when cleaning up checks: This https://github.com/lexibank/pylexibank/blob/674cdd0de1083cbffdea331fd90b66064d1d42de/src/pylexibank/commands/check_lexibank.py#L24-L27 could be removed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

codecov-io commented 4 years ago

Codecov Report

Merging #191 into master will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
- Coverage   99.42%   99.42%   -0.01%     
==========================================
  Files          29       29              
  Lines        1576     1573       -3     
==========================================
- Hits         1567     1564       -3     
  Misses          9        9
Impacted Files Coverage Δ
src/pylexibank/commands/check_lexibank.py 76.19% <ø> (-2.98%) :arrow_down:
src/pylexibank/commands/check_languages.py 95.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 674cdd0...6e334ae. Read the comment docs.