lexibank / pylexibank

The python curation library for lexibank
Apache License 2.0
18 stars 7 forks source link

post_process() hook for transparent CLDF schema modifications #206

Closed chrzyki closed 4 years ago

chrzyki commented 4 years ago

Occasionally, the CLDF schema needs to be modified after the CLDF creation with makecldf (e.g. to address warnings about empty tables etc.). Doing so explicitly in a post_process()-hook after the CLDF creation might be more transparent, easier to track and safer.

xrotwang commented 4 years ago

Just looked around how to implement this. It turns out that cmd_makecldf is called from cldfbench.Dataset._cmd_makecldf, not from pylexibank. But this hook would have to be called after cmd_makecldf and before _cmd_makecldf finishes (i.e. before things are written to disk). So I think we close this as too complicated/intrusive.