lexibank / pylexibank

The python curation library for lexibank
Apache License 2.0
18 stars 7 forks source link

update check profile command #242

Closed LinguList closed 3 years ago

LinguList commented 3 years ago

this is an enhancement of the output for the profile check command, also listing generated sounds and sounds which are modified (so not proper clts).

codecov-commenter commented 3 years ago

Codecov Report

Merging #242 (2b00541) into master (26cf39c) will decrease coverage by 1.23%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   98.91%   97.68%   -1.24%     
==========================================
  Files          32       32              
  Lines        2035     2076      +41     
==========================================
+ Hits         2013     2028      +15     
- Misses         22       48      +26     
Impacted Files Coverage Δ
src/pylexibank/commands/check_profile.py 55.93% <50.00%> (-44.07%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26cf39c...2b00541. Read the comment docs.

LinguList commented 3 years ago

@xrotwang, are you fine if I merge this for the time being? The additional functionalities are quite useful when adding new datasets.

xrotwang commented 3 years ago

Fine with me.

Johann-Mattis List @.***> schrieb am Sa., 19. Juni 2021, 16:37:

@xrotwang https://github.com/xrotwang, are you fine if I merge this for the time being? The additional functionalities are quite useful when adding new datasets.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lexibank/pylexibank/pull/242#issuecomment-864414594, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGUOKAVMZ2MO4HLYBIMEZDTTSTSPANCNFSM435FOGNQ .