search

lexibank / pylexibank

The python curation library for lexibank
Apache License 2.0
16 stars 7 forks source link

adding alignments #267

Open martino-vic opened 1 year ago

martino-vic commented 1 year ago

I'd like to add automatic alignments for cognate sets to my data, to later load and edit them with EDICTOR, and was wondering what the default way of doing this would be.

xrotwang commented 1 year ago

Hm, pylexibank's CLDF writer has an align_cognates method, see https://github.com/lexibank/pylexibank/blob/6075738ab3452095267c7443915f5416e7ff5589/src/pylexibank/cldf.py#L370-L381 but I'm not sure any lexibank dataset is actually using this functionality right now.

martino-vic commented 1 year ago

Worked like a charm, thank you. All I had to do was indeed just adding one line

xrotwang commented 1 year ago

The only usage of the line I found was in the pylexibank test suite - so that's inspiring some confidence :)

martino-vic commented 1 year ago

Not extremely urgent, but would it be possible to have a function like align_borrowings() in addition to align_cognates()? Like exactly the same thing as now, except that source and target words are aligned from borrowings.csv instead of cognates from cognates.csv and the results would be written to borrowings.csv instead of cognates.csv? My current workaround is simply to pretend that my borrowings are cognates, but idk if that's desirable in the long run. Thank you in advance for the help!