search

lexibank / tppsr

Tableaux Phonétiques des Patois Suisses Romands
Creative Commons Attribution 4.0 International
0 stars 0 forks source link

fix trailing spaces #19

Closed LinguList closed 4 years ago

LinguList commented 4 years ago

This fixes #18.

LinguList commented 4 years ago

I just wanted to re-run the creation for the metadata, to have clean versions, but if we use concepticon-2.4.0-rc.1, we lose the English glosses, which we added (they were called "english" before). Should we make concepticon-2.4.0-rc.2, to account for this?

LinguList commented 4 years ago

Alternatively, you could also just merge and re-run, @xrotwang ?

xrotwang commented 4 years ago

Yes, will do.

LinguList commented 4 years ago

Thanks and sorry for delay. The diffs show, that the changes were quite useful...

xrotwang commented 4 years ago

@LinguList you do know that you could get the english glosses running with --concepticon-version v2.3.0 - right?

LinguList commented 4 years ago

Were they called "GLOSS" in v2.3.0? I did not know this. In fact, we had ENGLISH in the column header, which is wrong, in version 2.3.0, didn't we?

LinguList commented 4 years ago

Yes, I made a PR for this https://github.com/concepticon/concepticon-data/pull/909

xrotwang commented 4 years ago

Yes, 2.3 had ENGLISH as header - but that doesn't matter too much as long as we adapt the code in lexibank_tppsr.py. We just have to make sure to adapt again - should we ever release TPPSR with a newer concepticon.