search

lexibank / zhangrgyalrong

Old Chinese Gyalrong cognates
Other
0 stars 0 forks source link

Problems with Concepticon mapping #9

Closed FredericBlum closed 7 months ago

FredericBlum commented 7 months ago

@LinguList Since it seems that I am not allowed to create a new branch in this repository, I'll create an issue instead of a PR. The lexibank-script needs an addtion of the following two lines around line 63:

                    Concepticon_ID=concept.concepticon_id,
                    Concepticon_Gloss=concept.concepticon_gloss,

In it's current state, the concept list gets loaded, but the Glosses and ID are not added to the CLDF set, hence they are lacking from the final dataset.

FredericBlum commented 7 months ago

remote: Permission to lexibank/zhangrgyalrong.git denied to FredericBlum.

chrzyki commented 7 months ago

Fixed in #10, I'll also give you all the permissions.

LinguList commented 7 months ago

Thanks, @FredericBlum. This particular dataset is a dataset I would not add to lexibank, however, since it contains, if you check the data, etymologigal data and concepts are linked to concepticon, but only for the root.

However, the much bigger dataset lexibank/lairgyalrong contains Rgyalrongic data for about 300 concepts per variety, so this is giving us some additional coverage for this subgroup.

FredericBlum commented 7 months ago

Thanks for the tip, I have removed zhangrgyalrong and added lairgyalrong to the lexibank-sheet accordingly.