search

lexical-lsp / lexical

Lexical is a next-generation elixir language server
782 stars 77 forks source link

Only index definitions on in dependencies by default #590

Closed scohen closed 4 months ago

scohen commented 4 months ago

In order to save memory, and avoid cluttering search results, we should not index references in dependencies.

aptinio commented 4 months ago

Is it enough to filter out files within the deps directory from here?

https://github.com/lexical-lsp/lexical/blob/2c49cd5d5609606c57a3f8eb11776e295b29f3d8/apps/remote_control/lib/lexical/remote_control/search/indexer.ex#L155-L161

scottming commented 4 months ago

@aptinio no, I think we still need to index the definitions of deps

aptinio commented 4 months ago

So, only index deps' definitions, but not their references. Got it. Thanks @scottming.

scohen commented 4 months ago

@aptinio I'm sorry, I started on this before I saw your comments, looks like you were looking in the right place.

aptinio commented 4 months ago

No problem @scohen. :relaxed: