lexical-lsp / lexical

Lexical is a next-generation elixir language server
874 stars 80 forks source link

Code Actions are broken #627

Closed scohen closed 7 months ago

scohen commented 7 months ago

Code actions broke with the commit that supported 1.16

This is because it changed the error messages, which broke the way actions worked. Code actions parse the error messages to figure out what's wrong and how to apply fixes.

Some of the changes were pretty dubious, like replacing double quotes with backticks, others eliminated many lines from the error message, which broke the replace with remote function action.

This is a pretty serious regression, those code actions were helpful.

scohen commented 7 months ago

Fixed by pr 625