scohen
commented
3 months ago I played around with this a little bit, here are my observations:
I did a big rename, renaming Lexical.Ast to Lexical.Aste for no particular reason. This absolutely crushed emacs, mostly due to emacs having to open a bunch of files, and doing the edits. By the time it came to close them, the expiration of the temporary open had elapsed, and I think this crashed the server. Emacs is famously bad at file I/O, so I don't think there's a ton to do other than open the documents permanently rather than temporarily. Something would need to track these opened files and close them when the operation was done.
One troubling bug that I noticed is that it renamed usages of Lexical.Ast.Detection in ast/env.ex to Detectione, which is strange.
VSCode fared much better, the rename was more or less instantaneous, and the rename completed successfully with no compile errors.However, the server crashed with the following
** (MatchError) no match of right hand side value: ["{\"jsonrpc\"", "\"2.0\",\"method\"", "\"textDocument/didOpen\",\"params\"", "{\"textDocument\"", "{\"uri\"", "\"file", "///Users/steve/Projects/lexical/apps/remote_control/lib/lexical/remote_control/search/indexer/extractors/struct_reference.ex\",\"languageId\"", "\"elixir\",\"version\"", "1,\"text\"", "\"defmodule Lexical.RemoteControl.Search.Indexer.Extractors.StructReference do\\n alias Lexical.Ast\\n alias Lexical.RemoteControl.Analyzer\\n alias Lexical.RemoteControl.Search.Indexer.Entry\\n alias Lexical.RemoteControl.Search.Indexer.Source.Reducer\\n alias Lexical.RemoteControl.Search.Subject\\n\\n require Logger\\n\\n @struct_fn_names [", "struct, ", "struct!]\\n\\n # Handles usages via an alias, e.g. x = %MyStruct{...} or %__MODULE__{...}\\n def extract(\\n {", "%, _, [struct_alias, {", "%{}, _, _struct_args}]} = reference,\\n %Reducer{} = reducer\\n ) do\\n case expand_alias(struct_alias, reducer) do\\n {", "ok, struct_module} ->\\n {", "ok, entry(reducer, struct_module, reference)}\\n\\n _ ->\\n ", "ignored\\n end\\n end\\n\\n # Call to Kernel.struct with a fully qualified module e.g. Kernel.struct(MyStruct, ...)\\n def extract(\\n {{", "., _, [kernel_alias, struct_fn_name]}, _, [struct_alias | _]} = reference,\\n %Reducer{} = reducer\\n )\\n when struct_fn_name in @struct_fn_names do\\n with {", "ok, Kernel} <- expand_alias(kernel_alias, reducer),\\n {", "ok, struct_module} <- expand_alias(struct_alias, reducer) do\\n {", "ok, entry(reducer, struct_module, reference)}\\n else\\n _ ->\\n ", "ignored\\n end\\n end\\n\\n # handles calls to Kernel.struct e.g. struct(MyModule) or struct(MyModule, foo", " 3)\\n def extract({struct_fn_name, _, [struct_alias | _] = args} = reference, %Reducer{} = reducer)\\n when struct_fn_name in @struct_fn_names do\\n reducer_position = Reducer.position(reducer)\\n imports = Analyzer.imports_at(reducer.analysis, reducer_position)\\n arity = length(args)\\n\\n with true <- Enum.member?(imports, {Kernel, struct_fn_name, arity}),\\n {", "ok, struct_module} <- expand_alias(struct_alias, reducer) do\\n {", "ok, entry(reducer, struct_module, reference)}\\n else\\n _ ->\\n ", "ignored\\n end\\n end\\n\\n def extract(_, _) do\\n ", "ignored\\n end\\n\\n defp entry(%Reducer{} = reducer, struct_module, reference) do\\n document = reducer.analysis.document\\n block = Reducer.current_block(reducer)\\n subject = Subject.module(struct_module)\\n\\n Entry.reference(\\n document.path,\\n block,\\n subject,\\n ", "struct,\\n Ast.Range.fetch!(reference, document),\\n Application.get_application(struct_module)\\n )\\n end\\n\\n defp expand_alias({", "__aliases__, _, struct_alias}, %Reducer{} = reducer) do\\n Analyzer.expand_alias(struct_alias, reducer.analysis, Reducer.position(reducer))\\n end\\n\\n defp expand_alias({", "__MODULE__, _, _}, %Reducer{} = reducer) do\\n Analyzer.current_module(reducer.analysis, Reducer.position(reducer))\\n end\\n\\n defp expand_alias(alias, %Reducer{} = reducer) do\\n {line, column} = reducer.position\\n\\n Logger.error(\\n \\\"Could not expand alias", " \#{inspect(alias)} at \#{reducer.analysis.document.path} \#{line}", "\#{column}\\\"\\n )\\n\\n ", "error\\n end\\nend\\n\"}}}Content-Length", " 2625\n"]
(lx_server 0.5.0) lib/lexical/server/transport/std_io.ex:104: LXical.Server.Transport.StdIO.parse_header/1
(elixir 1.14.5) lib/enum.ex:1658: Enum."-map/2-lists^map/1-0-"/2
(lx_server 0.5.0) lib/lexical/server/transport/std_io.ex:60: LXical.Server.Transport.StdIO.loop/3
(stdlib 4.3.1.2) proc_lib.erl:240: :proc_lib.init_p_do_apply/3
Initial Call: LXical.Server.Transport.StdIO.init/1
Ancestors: [LXical.Server.Supervisor, #PID<0.143.0>]
Message Queue Length: 0
scottming
This PR is primarily copied from #374, but compared to the previous implementation, we have made two changes:
TopLevel.Parent.ChildtoTopLevel.Child, or renaming some middle parts, likeTopLevel.Parent.ChildtoTopLevel.Renamed.Child.I personally really like this change, especially the second point, which makes module renaming much more practical.