lexical-lsp / lexical

Lexical is a next-generation elixir language server
874 stars 80 forks source link

Implement callback completions #640

Closed Moosieus closed 6 months ago

Moosieus commented 7 months ago

Callback completions should now expand to their full def-blocks, preceded with an impl tag.

In a module use-ing a behaviour, typing def | should result in the following completion options:

Moosieus commented 7 months ago

CI seems to be failing due to an unrelated issue:

 Could not fetch /builds/otp/ubuntu-22.04/builds.txt from any hex.pm mirror

In the meantime, I need to take a second pass at the callback completion and add additional tests. Presently def handle| doesn't overwrite the original def properly.

scohen commented 6 months ago

@Moosieus I re-ran the tests, these failures seem legit.

Moosieus commented 6 months ago

Keeping the sorting as-is for now since I've already pitched the overhaul in #643.