lexical-lsp / lexical

Lexical is a next-generation elixir language server
874 stars 80 forks source link

Update nix mix deps sha256 #673

Closed zoedsoupe closed 6 months ago

zoedsoupe commented 6 months ago

On commit 2178b4b there was an update to dialyzer mix dependency. That causes a new state for mix.lock and therefore a new sha256 hash for the mix FOD deps build with nix.

scohen commented 6 months ago

@hauleth the detection scripts don't seem to be working.

skbolton commented 6 months ago

I am starting to think that it would be better to not try and have the nix definition stay up to date with main. It could make more sense to go to a release model and pin a tag and then as part of the release process update the nix definition.

skbolton commented 6 months ago

but for the sake of keeping what is in place working it looks like there still might be permissions errors image https://github.com/lexical-lsp/lexical/actions/runs/8012127382/job/21886809560

Or this mysterious error on the last deps update https://github.com/lexical-lsp/lexical/actions/runs/8459424205/job/23175709907

scohen commented 6 months ago

I fixed the permissions error. The other error doesn't look like anything to me.

skbolton commented 6 months ago

@scohen any reason to not merge this? Otherwise nix folks are going to have to wait till the next time deps update (and the action runs correctly) in order to build main successfully.

scohen commented 6 months ago

One reason is that main isn't in a great state right now

skbolton commented 6 months ago

Sounds good @scohen. Just wanted to make sure you weren't thinking things were resolved by the action fix.

hauleth commented 6 months ago

Ahh, yeah. I need to update the script a little, as it is expected to fail, so it should take that into the account.

hauleth commented 6 months ago

683 supersedes this PR

scohen commented 6 months ago

Closing in favor of #683