lexical-lsp / lexical

Lexical is a next-generation elixir language server
888 stars 82 forks source link

The Nix hash isn't updated on CI #816

Closed akirak closed 2 months ago

akirak commented 3 months ago

The Nix workflow successfully finishes without actually pushing the update. Due to the branch protection rule, the Nix hash is never updated from CI.

An example from the recent run:

[main f6994d0] Update Nix hash of Mix deps 1 file changed, 1 insertion(+), 1 deletion(-) remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: Changes must be made through a pull request.
To https://github.com/lexical-lsp/lexical ! [remote rejected] main -> main (protected branch hook declined) error: failed to push some refs to 'https://github.com/lexical-lsp/lexical'

The branch protection rule itself is sensible, so the workflow should be triggered on pull requests instead?

Also, you could use git-auto-commit-action for pushing the update.