SMS notification only plays while in a call (since r277)

[GoogleCodeExporter]

What steps will reproduce the problem?
Checkout any revision from 277 to current (282), compile and install. When an 
SMS is received, a notification is only played if the phone call state is 
CALL_STATE_OFFHOOK (i.e. we're in a call and do not have calls pending to pick 
up). See 
http://developer.android.com/reference/android/telephony/TelephonyManager.html#C
ALL_STATE_IDLE

What is the expected output? What do you see instead?
A notification is played only if we're not in a call (i.e. call state is 
CALL_STATE_IDLE).

What version of the product are you using? On what operating system?
SmsPopup from SVN checkout r282 on a stock, unrooted Nexus One running Android 
2.2.

Please provide any additional information below.
I have attached a patch (callstate.patch) which should fix the regression.

Original issue reported on code.google.com by mathias...@gmail.com on 10 Oct 2010 at 12:42

Attachments:

• callstate.patch

[GoogleCodeExporter]

I assume this will take care of the issue of the phone vibrating when receiving 
a text while on a call? I'm still waiting for this fix to be deployed.

Original comment by mojo3323 on 2 Nov 2010 at 7:54

[GoogleCodeExporter]

Yeah. The fix worked reverse of what it was supposed to.

Original comment by mathias...@gmail.com on 3 Nov 2010 at 11:00

[GoogleCodeExporter]

thanks, just corrected this.

Original comment by adam.eve...@gmail.com on 19 Nov 2010 at 12:29

• Changed state: Fixed