lexicongovernance / pluraltools-backend

Backend implementation of the plural voting tool.
https://demo.lexicongovernance.org/
GNU General Public License v3.0
3 stars 1 forks source link

Remove logic to automatically send registration data to question options #332

Closed MartinBenediktBusch closed 4 months ago

MartinBenediktBusch commented 4 months ago

Note

PR can be reviewed but should be merged to develop only after v.2.5.0 https://github.com/lexicongovernance/pluraltools-backend/pull/322 has been merged to main. Furthermore, this PR should only be merged from develop to main once registration for existing proposals gets closed.

The PR itself removes the questionOptionType column which can be either Title, Subtitle, or Null from registration fields,including the functionality to pass this data to the question options table. However, I kept the questionId column in registrationFields to be able to to distinguish registrations by questionId.

Furthermore, I kept the registrationId and userId in the `questionOptions table to be able to uniquely identify a question option by user and registration. Furthermore, setting registrationId and userId equal to null retains the functionality to set custom question options that are defined by us.

Note: Removing this feature requires the admin to insert registration options to the question options table. This must be developed.

MartinBenediktBusch commented 4 months ago

Make PR consistent with new backend changes.