search

lexiconhq / lexicon

Built with Expo, React Native, and GraphQL, Lexicon is a pre-built mobile discussions app that you can customize for your users.
https://lexicon.is
MIT License
182 stars 32 forks source link

Upgraded Expo SDK to 47 and React to 18 #22

Closed shafique17z closed 1 year ago

shafique17z commented 1 year ago

Type of PR

Description

This PR upgrades the Expo version from 45 to 47 and updates React to version 18.

Changes

Date: Tuesday, 4 April 2023 #### **Contextual Changes:** - Upgraded Expo version from 45 to 47 - Updated React to version 18
Kinostrome commented 1 year ago

Hey there, thanks for doing this! We really appreciate it. We'll take a look and let you know if we need any changes.

bonsaibauer commented 1 year ago

I used this pull request because otherwise it's not possible to have a test instance with Expo Go. I encountered the following error while running the npm test run debugging method:

src/components/Markdown.tsx:97:8 - error TS2322: Type '{ children: string; renderer?: AstRenderer | undefined; markdotyle?: boolean | undefined; debugPrintTree?: boolean | undefined; onLinkPress?: ((url: string) => boolean) | undefine}; style: { ...; }; }' is not assignable to type 'IntrinsicAttributes & MarkdownProps'. Property 'children' does not exist on type 'IntrinsicAttributes & MarkdownProps'.

I was able to build the app with npx epo start, but I don't see any profile pictures in the posts and it crashes sometimes. I could not fix the Markdown Issue...

Kinostrome commented 1 year ago

Thanks for testing @bonsaibauer.

@shafique17z we'll need you to fix the issue described above before the review process continues.