lexik / LexikTranslationBundle

This Symfony bundle allow to import translation files content into the database and provide a GUI to edit translations.
MIT License
428 stars 262 forks source link

Symfony 3.3.5 Warning: Illegal offset type in isset or empty #264

Closed denya-vs closed 7 years ago

denya-vs commented 7 years ago

When I updated symfony to version 3.3.5 and clear cache. I catch exception about definition:

davidskaraboo commented 7 years ago

What was your previous version?

denya-vs commented 7 years ago

1.first my version is 3.1

  1. Then I update symfony to 3.2. and all worked is correct.
  2. Then I update symfony to 3.3.5 and catch excetion Type error: Argument 5 passed to Symfony\Bundle\FrameworkBundle\Translation\Translator::__construct() must be of the type array, object given, called in /var/www/var/cache/dev/appDevDebugProjectContainer.php on line 2860
  3. Then I find pull request and commit when this exception fixed, and chechout to dev-master 9ae3d76
  4. Then I catch new exception, described above.
denya-vs commented 7 years ago

265

pawelkolanowski commented 7 years ago

+1

cioll commented 7 years ago

👍

Growiel commented 7 years ago

The patch at #265 is working fine for me.

Can we please have to merged AND a tag made ? All this messing around with the composer.json and relying on dev-master makes me unconfortable.

Thanks.

acassan commented 7 years ago

+1 need merge

acassan commented 7 years ago

Fix build by this one:

$className = sprintf('lexik_translation.%s.translation_storage.class', $storage);
$storageDefinition->setArguments($args);
$storageDefinition->setClass('%'.$className.'%');

Missing this line on your build: $storageDefinition->setArguments($args);

marcossegovia commented 7 years ago

+1 need merge

sdieunidou commented 7 years ago

fixed