Lexik don't load Symfony4 translations

lexik / LexikTranslationBundle

This Symfony bundle allow to import translation files content into the database and provide a GUI to edit translations.

MIT License

429 stars 263 forks source link

Lexik don't load Symfony4 translations #333

Open info-droid opened 6 years ago

info-droid commented 6 years ago

Hi,

In DependencyInjection/LexikTranslationExtension.php, you never try to find translation files in framework.translator.default_path.

So you don't find translations from new /translations/ Symfony 4 directory.

I've missed something, or it's normal ?

rjwebdev commented 6 years ago

I already created a pull request for this problem: https://github.com/lexik/LexikTranslationBundle/pull/331

Seb33300 commented 5 years ago

Your pull request doesn't use framework.translator.default_path option.

So if the option value is modified, this bundle will not work.

shengjie commented 5 years ago

Hello , symfony 3.4 also supports loading translations in translations/ folder,

see https://symfony.com/doc/3.4/translation.html#translation-resource-file-names-and-locations

fsoedjede commented 5 years ago

Hello! @rjwebdev the pull request your made only handle SF4+ but as @shengjie quote it, in 3.4 we can have the new structure so your fix doesn't work if we are using 3.4. I've created this PR #354