lexik / LexikTranslationBundle

This Symfony bundle allow to import translation files content into the database and provide a GUI to edit translations.
MIT License
427 stars 262 forks source link

Fix translator dirs by relying on `translator.default_path` #333 #354

Closed fsoedjede closed 3 years ago

fsoedjede commented 5 years ago

Fix #333

Rely on translator.default_path added since 3.4.0 instead of Kernel::MAJOR_VERSION

Davidmattei commented 4 years ago

+1

timvermaercke commented 4 years ago

Wow. I really need this to be merged. Also, the bundle doesn't look at the paths configured in translator.paths.

StijnMaenhaut commented 4 years ago

+1

nithiz commented 3 years ago

+1

bartmcleod commented 3 years ago

@fsoedjede can you rebase on current master or direct the PR to the 3.4 or 4.4 branch. Travis now wants to build against ancient version, not supported by master.

fsoedjede commented 3 years ago

@bartmcleod rebase done to the branch 3.4

Sorry for the spam in pushes 🤦🏽