search

lexik / LexikTranslationBundle

This Symfony bundle allow to import translation files content into the database and provide a GUI to edit translations.
MIT License
422 stars 259 forks source link

Symfony 5 compability #367

Closed girayk closed 3 years ago

girayk commented 4 years ago

Symfony 5 upgrade, I didn't test 100%, but basic functions for ORM, which I am using, there are working.

gilles-g commented 4 years ago

Hi,

Thx for your work, but I can't merge your PR for now.

see https://github.com/lexik/LexikTranslationBundle/issues/368

noniagriconomie commented 3 years ago

hi @spike31 @girayk

is there a way to create sub branches, and merge this PR in the v5 one + new tag? then write on the readme that this bundle only maintain sf4 sf5 for example, and for earlier version a dev should use previous releases

it would be very cool to have this bundle 👍 i can help if needed

cheers!

bartmcleod commented 3 years ago

@girayk I am sorry I did not see your work earlier. I have made a Symfony 5 release without this. For now, I will close this PR, as you can now use the bundle with Symfony 5. If you notice things that I missed, please creat a new PR for them.