search

lexik / LexikTranslationBundle

This Symfony bundle allow to import translation files content into the database and provide a GUI to edit translations.
MIT License
422 stars 259 forks source link

To help fix #368 provide a development environment based on docker #375

Closed bartmcleod closed 3 years ago

bartmcleod commented 3 years ago

To help fix #368, provides a development environment based on docker which allows the tests to pass

bartmcleod commented 3 years ago

@spike31 As you can see, it was probably pretty simple to make the Travis build pass for this branch. Not everything in this PR was needed to make it so, possibly only the addition of the mysql service to the Travis build and the elimination of builds that are irrelevant to this branch (since it need only be compatible with Symfony 3.4). If you want me as a contributor, I will be happy to help with other branches. If changes are needed on this PR, just let me know.

gilles-g commented 3 years ago

Hi @bartmcleod,

I appreciate your efforts for this bundle, but I can't merge this PR because we can't have a Dockerfile fos this, only for run tests. Travis is the tool for that. I understand it can be complex to use, but we can't have a dockerfile just for a symfony bundle.

My vision for the futur of the bundle, as I said in the other issue, is to let old tags for PHP 5.6 or symfony 34 and don't touch them.

So don't worry about symfony 3.4 and PHP 5.6, because it's the past :D really, I maintain other bundles and app, and that bundle works perfectly with SF 3.4... Travis change something and builds are broken, why? Don't know, and I don't have the time for search..

You can change your PR with just the update for Travis? I could add you as a contributor, only if you don't add Dockerfile in the futur :D

bartmcleod commented 3 years ago

Will create a new PR