search

lexik / LexikTranslationBundle

This Symfony bundle allow to import translation files content into the database and provide a GUI to edit translations.
MIT License
422 stars 259 forks source link

symfony/symfony and mongo requirements moved to require-dev #380

Closed bartmcleod closed 3 years ago

bartmcleod commented 3 years ago

To allow installation with composer, symfony/symfony should not be required, because it would conflict with a symfony application. Mongodb is not strictly a requirement, but it is required for development of this bundle, so it should go to require-dev.

gilles-g commented 3 years ago

@bartmcleod

But you need symfony frameworkBundle? Or doctrine/orm-bundle?

I'm not sure if it's a good idea to don't have deps

gilles-g commented 3 years ago

If you do a search in the repository with symfony, you will found "frameworkbundle, Form, etc"

bartmcleod commented 3 years ago

@spike31 the symfony bundle has been replace by symfony/symfony. It conflicts with a Symfony full project, so it can't be in require.

We do need doctrine orm. Did I remove too much? [I believe it wasn't in the deps, I think it isn't to allow others to have a different version, but I am not sure about the reasons]

gilles-g commented 3 years ago

I understand for symfony/symfony, but the bundle use symfony classes. So we need to tell to composer if the bundle can be installed for SF 3.4 or 5.

bartmcleod commented 3 years ago

Symfony 3.4 is in a different branch, we don't consider it here anymore.

I don't know how to tell composer that. If we put symfony/symfony in the requirements it won't install at all.

If we put symfony/framework-bundle in the requirements composer says it has been replaced by symfony/symfony

bartmcleod commented 3 years ago

I am ok with anything in composer.json that works. I just had a lot of trouble to make it work at all.

gilles-g commented 3 years ago

The 3.4 branch is just for the bundle, in packagist, there is no constraints to install the bundle.

If we use classes from FrameworkBundle, just add the symfony/frameworkBundle and pass tests. Same for others namespaces.

If think you can have a look to the https://github.com/lexik/LexikJWTAuthenticationBundle , the composer and travis. Because the maintenair is a member of the core team and the bundle has goods practices

bartmcleod commented 3 years ago

I looked at it and from what I see it must be possible that way.

gilles-g commented 3 years ago

Ok, IMO, tags 4.4 and 4.4.1 not very good, because they have no deps...

bartmcleod commented 3 years ago

I can replace those in the evening, until we get it right. Sorry for the inconvenience.

gilles-g commented 3 years ago

8 years of open source help me :D no problem