search

lexik / LexikTranslationBundle

This Symfony bundle allow to import translation files content into the database and provide a GUI to edit translations.
MIT License
422 stars 259 forks source link

Broken exporter #385

Closed nithiz closed 3 years ago

nithiz commented 3 years ago

Hello,

Running the exporter will give me an error because the $container->hasDefinition('lexik_translation.exporter_collector') check always fails.

When i change this to $container->hasDefinition('Lexik\Bundle\TranslationBundle\Translation\Exporter\ExporterCollector') everything works as expected.

Am i doing something wrong or is this a bug?

bartmcleod commented 3 years ago

This is likely a bug, although I tested with Symfony 5.2 and the export worked. I noticed however that this hasDefinition call still exists for old style service definitions and that does not seem to work, I had to fix acouple of them. This likely is just another of those. Will label it bug.

bartmcleod commented 3 years ago

@nithiz which version did you install? I do get an issue with the exporter related to the collector, but it is different. Also, I can see that in master, this has been solved, so my guess is you are using a 4.* version?

bartmcleod commented 3 years ago

@nithiz Please confirm that this is fixed with v5.0.1 and close the issue.

nithiz commented 3 years ago

@bartmcleod Thanks for the update, i will check it out later today :)

nithiz commented 3 years ago

@bartmcleod Thanks! It's working now, i was using 5.0.0 before.