search

lexik / LexikTranslationBundle

This Symfony bundle allow to import translation files content into the database and provide a GUI to edit translations.
MIT License
425 stars 262 forks source link

Symfony 6 Support - Compatible with PHP 7.4 & 8.0 #413

Closed raziel057 closed 2 years ago

raziel057 commented 2 years ago

Please find here a PR that fix SF5.4 deprecations that I could test using PHP 7.4 and 8.0.

bartmcleod commented 2 years ago

I will merge it, but can we please in the future drop compatiblity with php 7.4? We have the 5.2 branch for it. In master, we will be compatible with Symfony 6 and php 8.

raziel057 commented 2 years ago

@bartmcleod In fact it was to be merged also in 5.x branch to fix deprecations that are raised in 5.3 & 5.4.

bartmcleod commented 2 years ago

@raziel057 I will create a 5.3 branch then on master

bartmcleod commented 2 years ago

Done, we will keep php 7.4 compatibility in the 5.3 branch. This gives us the freedom to use php 8 features in master.

raziel057 commented 2 years ago

@bartmcleod 👍