search

lexik / LexikTranslationBundle

This Symfony bundle allow to import translation files content into the database and provide a GUI to edit translations.
MIT License
419 stars 255 forks source link

Fix deprecations for SF6.3 #431

Closed raziel057 closed 12 months ago

raziel057 commented 12 months ago

Fix deprecation raised on Symfony 6.3 related to missing "void" return type in configure methods of commands:

Method "Symfony\Component\Console\Command\Command::configure()" might add "void" as a native return type declaration in the future. Do the same in child class "Lexik\Bundle\TranslationBundle\Command\ImportTranslationsCommand" now to avoid errors or add an explicit @return annotation to suppress this message.

Method "Symfony\Component\Console\Command\Command::configure()" might add "void" as a native return type declaration in the future. Do the same in child class "Lexik\Bundle\TranslationBundle\Command\ExportTranslationsCommand" now to avoid errors or add an explicit @return annotation to suppress this message.

Method "Symfony\Component\HttpKernel\Bundle\Bundle::build()" might add "void" as a native return type declaration in the future. Do the same in child class "Lexik\Bundle\TranslationBundle\LexikTranslationBundle" now to avoid errors or add an explicit @return annotation to suppress this message.

Note that the "void" return type have been introduced in PHP 8.1 so it's in line with the constraint in composer.json.

bartmcleod commented 12 months ago

@raziel057 The tests fail

raziel057 commented 12 months ago

@raziel057 The tests fail

I seen this. It's not related to those commits but related to changes in a new release of doctrine annotation. No auto build happened from long time on this bundle.

bartmcleod commented 12 months ago

I fixed the auto build, but apparently, since then it broke. We need to fix that, as passing unit tests are the only check apart from looking at the code and thinking it looks reasonable :-) So @raziel057 if you can fix the tests that would be great, otherwise I will need to find some time to do so

raziel057 commented 12 months ago

I spent time to test and fix issues related to DEV environment to run the tests: https://github.com/lexik/LexikTranslationBundle/pull/432

raziel057 commented 12 months ago

@bartmcleod Do you I need to do something else for integration of the change here?

bartmcleod commented 12 months ago

@raziel057 probably need to merge master back in