search

lexik / LexikTranslationBundle

This Symfony bundle allow to import translation files content into the database and provide a GUI to edit translations.
MIT License
425 stars 262 forks source link

Update composer.json #448

Closed HecFranco closed 9 months ago

bartmcleod commented 10 months ago

@HecFranco this seems to be the same PR as the earlier one? And it should be made against master. The 6.0 branch is to be used when your changes are specific to that version. Lastest and greatest should be targeting master.

HecFranco commented 9 months ago

@bartmcleod I have already changed the source branch.

bartmcleod commented 9 months ago

@HecFranco I wonder why no checks are run, maybe I need to reconfigure something... Also would need to know it it actually works with SF 7.

k0d3r1s commented 9 months ago

this is last library blocking my upgrade to 7.0. any updates here? need any help?

bartmcleod commented 9 months ago

@k0d3r1s We can fix this, probably.

bartmcleod commented 9 months ago

This PR is incomplete. It will not allow to "require" the package, because you only added sf 7 under "require-dev". Also, in sf -7 I see a lot of additional dependencies, that are not installed with this bundle, and should have been installed, so more dependencies will need to be added.

bartmcleod commented 9 months ago

While I now have a branch on my repo that supports installation with Sf 7, it fails to load the translations in the browser due to a javascript error.

bartmcleod commented 9 months ago

I close this, because a lot more had to be done, the UI also had bugs, possibly introduced by using a new angular version (that must be it). It is also possible bug reports exist for those, I will have a look if so and if they can be closed. In any case, I will create a new PR for SF 7 and probably merge that. It is possible that the UI fixes must be backported to the 6 branch.