lexmag / statix

Fast and reliable Elixir client for StatsD-compatible servers

https://hexdocs.pm/statix

ISC License

275 stars 82 forks source link

Should connect accept configuration? #39

Closed keathley closed 4 years ago

keathley commented 5 years ago

We often need to pre-configure statix at runtime before running the connect/0 function. Would it make sense to allow connect to accept a configuration? This would allow us to avoid mutating the application env. I can take a look at this if it's interesting to y'all.

mroach commented 5 years ago

We're having to do the same thing as our statsd servers are defined by ENV vars per data centre (a.la Consul). In general it makes sense to support runtime configuration especially for external services.

Regarding the discussions in #41, this would also be a solid feature to add to a Bleacher Report fork.

lexmag commented 4 years ago

50 should make this possible. Feel free to review the PR. :bowtie: