lexogrine / hud-manager

All-in-one broadcast & HUDs Manager
https://lhm.gg
Other
273 stars 34 forks source link

Last round of half and game will store win_type and winner incorrectly #30

Open Barsnes opened 4 years ago

Barsnes commented 4 years ago

A typical round would be stored in the API wtih all the information needed, however for the last round of the half, and last round of the game, the winner and win_type are stored as nulls. This is consistent throughout all demos I've tested with

correct:

           "round": 1
            "players": {
              "76561198130490651": {
                "kills": 1,
                "killshs": 1,
                "damage": 77
              }, { ... }
            },
            "winner": "T",
            "win_type": "elimination"
          },

incorrect:

           "round": 15
            "players": {
              "76561198130490651": {
                "kills": 1,
                "killshs": 1,
                "damage": 77
              }, { ... }
            },
            "winner": null,
            "win_type": null
          },
Barsnes commented 4 years ago

I have tested with demos from these matches: https://www.hltv.org/matches/2343529/w7m-vs-red-canids-clutch-season-3 https://www.hltv.org/matches/2343501/gambit-youngsters-vs-pact-eden-arena-malta-vibes-cup-8 https://www.hltv.org/matches/2343499/forze-vs-lvlup-eden-arena-malta-vibes-cup-8

osztenkurden commented 4 years ago

It seems like its the way demos are saved - some config system (ex ESEA) makes demos not sending the same data as on live matches, therefore making demos unusable. I will look into it though

Barsnes commented 4 years ago

It seems like its the way demos are saved - some config system (ex ESEA) makes demos not sending the same data as on live matches, therefore making demos unusable. I will look into it though

I've done some testing and it seems like it's because of the way eBot sends data and ends round 15 and the last round