search

lexrus / LTBouncyPlaceholder

A learning-by-doing UITextField extension written in Swift
490 stars 47 forks source link

UISearchBar placeholder missing #2

Closed ashchan closed 9 years ago

ashchan commented 9 years ago

LTBouncyPlaceholder is awesome, but it seems to break UISearchBar. When it's used in a project the search bar's placeholder is not showing.

lexrus commented 9 years ago

It's unsafe to swizzling drawPlaceholderInRect() of UITextField class. The text field in UISearchBar whose class name is UISearchBarTextField is a subclass of UITextField. I guess the best practice to use swizzling is not to use it under most circumstances.

ashchan commented 9 years ago

@lexrus Agree. Subclass works more safely than extension or swizzling. Thanks for the quick fix!