search

lexrus / MMDB-Swift

A tiny wrapper for libmaxminddb which allows you to lookup Geo data by IP address.
Apache License 2.0
123 stars 59 forks source link

Remove bundled Geolite2 db due to license change #15

Closed zhuhaow closed 4 years ago

zhuhaow commented 4 years ago

Due to license change, https://dev.maxmind.com/geoip/geoip2/geolite2/ we are no longer able to download Geolite2 db without manual setting up.

  1. Removed db update script
  2. Removed bundled db binary from MMDB target, MMDB now must be inited with a path to the db binary
  3. Moved bundled db to test target for only testing purpose. The binary can be released since it was obtained under old license. But there is no way to update it now.

I removed bundled outdated DB instead of just removing the update script.

IMHO, providing an outdated database basically enables some developers to never update the database, which would impact the final user experience. Instead, developers should not depend on MMDB to provide a solution but try to find a way to make sure the database is up to date.

Fixing #14

lexrus commented 4 years ago

LGTM. Thank you, @zhuhaow