lexus2k / lcdgfx

Driver for LCD displays running on Arduino/Avr/ESP32/Linux (including Rasperry) platforms
MIT License
377 stars 52 forks source link

Updating "Arduino SAMD Boards" package to 1.8.10 has broken compilation #36

Closed stealth-ultd closed 3 years ago

stealth-ultd commented 3 years ago

Describe the bug

The update of the "Arduino SAMD Boards" package to 1.8.10 (Arduino IDE) seems to have broken compilation for the lcdgfx library ("fatal error / compilation terminated" – see below). Downgrading to package 1.8.9 removes the compiler error. Upgrading to 1.8.10 re-instates the error.

To Reproduce Steps to reproduce the behavior:

  1. Update to "Arduino SAMD Boards" 1.8.10 in Arduino IDE
  2. Click 'Compile' in IDE
  3. Compiler terminates: "…/Arduino/libraries/lcdgfx/src/lcd_hal/arduino/io.h:42:14: fatal error fatal error: avr/pgmspace.h: No such file or directory

    include <avr/pgmspace.h>

          ^~~~~~~~~~~~~~~~

    compilation terminated. exit status 1 Error compiling for board Arduino MKRZERO."

Expected behavior Expected: no compiler error (as confirmed with SAMD Board package 1.8.9)

Screenshots n/a

Please complete the following information:

Additional context n/a

lexus2k commented 3 years ago

They changes some things in their release, hope that the fix above will help you. Also, pull requests are very welcome to development branch: v1.0.0_dev

stealth-ultd commented 3 years ago

Thanks for the quick action, it compiles like a charm, all fixed!