search

lexus2k / ssd1306

Driver for SSD1306, SSD1331, SSD1351, IL9163, ILI9341, ST7735, PCD8544, Nokia 5110 displays running on Arduino/ESP32/Linux (Rasperry) platforms
MIT License
676 stars 127 forks source link

lcd_common.c:100:17: error: Uninitialized variable: args [uninitvar] #117

Closed Harvie closed 3 years ago

Harvie commented 3 years ago

Hello, i've "accidentaly" checked the ssd1306 using cppcheck static analyzer and it seems quite ok, only one tiny error was found:

$ cppcheck --force . >/dev/null
src/lcd/lcd_common.c:100:17: error: Uninitialized variable: args [uninitvar]
            if (args < 0)
                ^
lexus2k commented 3 years ago

Hi @Harvie

Thank you for the finding, but my cppcheck doesn't show any warning. I fixed this error (you can see commit in this issue).

Best regards

Harvie commented 3 years ago

Thank you for the finding, but my cppcheck doesn't show any warning.

i've just checked 1.8_dev branch and the warning has disappeared after your changes.

For the reference:

$ cppcheck --version
Cppcheck 2.2
lexus2k commented 3 years ago

@Harvie

Thank you very much.