Refactor ssd1306_platform_i2cInit to commonize all platform signatures.

lexus2k / ssd1306

Driver for SSD1306, SSD1331, SSD1351, IL9163, ILI9341, ST7735, PCD8544, Nokia 5110 displays running on Arduino/ESP32/Linux (Rasperry) platforms

MIT License

655 stars 125 forks source link

Refactor ssd1306_platform_i2cInit to commonize all platform signatures. #74

Closed montaguk closed 5 years ago

montaguk commented 5 years ago

Addressing build issues that were present on PR #72. I have tested this change and it appears to be working on vanilla esp-idf (esp32), the AVR wrapper around ESP32, and Linux SDL.

Is I mentioned in my final comment on #72, there appears to be another issue with the AVR build that is unrelated to my change. Making a few local change to allow the warnings results in a successful compilation of the library, but I don't have any AVR hardware on which to test.

montaguk commented 5 years ago

Addressed review comments with most recent commit. Thanks for the feedback!

lexus2k commented 5 years ago

I made "publish review". Let me know if you don't see comments still