search

lexxmark / winflexbison

Main winflexbision repository
GNU General Public License v3.0
403 stars 117 forks source link

CI: Test Visual Studio 2022 64-bit builds #83

Closed Croydon closed 2 years ago

Croydon commented 2 years ago

This adds Visual Studio 2022 64-bit builds to the build matrix.

The other builds jobs are unchanged

lexxmark commented 2 years ago

Win32 config is a default for Winflexbison package. I don't remember if original flex/bison code have been adopted for x64 compilation. If they were, we could switch to x64 packages then.

But I don't see any advantages to use x64 - I have not heard any issues with 32bit winflexbison so far.

GitMensch commented 2 years ago

I don't remember if original flex/bison code have been adopted for x64 compilation. If they were, we could switch to x64 packages then.

They definitely are, since years.

Croydon commented 2 years ago

I don't see any actual advantage of dropping existing 32-bit builds from CI unless you actually want to end support for 32-bit builds altogether.

I added only 64-bit builds for VS 2022 because of two things: 1) I think that the existing coverage for 32-bit builds is good enough. VS 2022 is 64-bit only itself. If someone compiles their own builds, they almost certainly target 64-bit 2) I think that it is a valid option to drop 32-bit targets in a few years down the road, just not maybe right now

But all of this is kinda out of the scope of this pull request. Just let me know if you want 32-bit builds with VS 2022 covered in CI too or not.

lexxmark commented 2 years ago

Let's leave VS2022 with x64 mode only as a little step into a future full x64 migration.

We can easily bring win32 mode at any time if required.

GitMensch commented 2 years ago

Thanks for the adjustments!