search

lexxpavlov / LexxpavlovSettingsBundle

This bundle helps you to manage your settings in Symfony2/3 project
MIT License
10 stars 10 forks source link

Missing options when using ckeditor type #6

Closed roldan closed 7 years ago

roldan commented 7 years ago

Hi,

I'm using lexxpavlov/settingsbundle 1.3.1 and egeloen/ckeditor-bundle 5.0.3 and after installing both bundles and tried to create or edit a setting, I get this exception:

screenshot from 2017-06-25 05-42-23

The same occurs for all this vars: async, jquery, require_js, auto_inline, inline, input_sync, filebrowsers

So I noticed that there are some missing options here:

https://github.com/lexxpavlov/LexxpavlovSettingsBundle/blob/master/Form/Type/SettingValueType.php#L49

That the ckeditor widget needs here:

https://github.com/egeloen/IvoryCKEditorBundle/blob/master/Resources/views/Form/ckeditor_widget.html.twig

Maybe you should add default value for these vars, what do you think about?

Best, Matías

lexxpavlov commented 7 years ago

Maybe, this variables was created in fifth version of egeloen/ckeditor-bundle. I will try to fix it in a two days.

roldan commented 7 years ago

Great Alexey, thanks!

lexxpavlov commented 7 years ago

A new 1.3.2 version fixes this issue. CKEditor will use settings of IvoryCKEditorBundle now.