leycec / fsnrnue

Lutris-based Linux installer for Fate/stay night [Réalta Nua] Ultimate Edition
GNU General Public License v3.0
66 stars 15 forks source link

Patches are not downloaded properly #3

Closed tanahy closed 3 years ago

tanahy commented 4 years ago

First of all, thanks for making this possible, I already played the game but I wanted to test this version in case I could help with debugging.

I followed the instructions stated in the README for linux using the one clicker installer. Everything when just totally fine but all the patch files that were downloaded weighted between 0B and 3KiB.

The issue is easily solved by downloading the patches from the google drive links in the Beast's Liar forum as stated in the instructions. However, I feel like this is not the intended behaviour and I should report it in case something weird is going on, as it happened with all the patches (I installed them all except the OP one).

leycec commented 4 years ago

Yup. Thanks for publicly noting this, @tanah. Your dedication to the crème-de-la-crème of the visual novel world is commendable.

It's suspiciously concerning that the Ultimate Edition installer failed to properly fetch any patches for you. That's Critical Badness™ right there. In my case, the installer behaved less bad but still bad. Thus, the FAQ entry that you astutely noted. Specifically, the installer:

誰も知らない! ("Nobody knows why!") Something weird is definitely going on – but I'm unsure whether we can minimize that weirdness from our end. A Lutris script can only do so much and that's usually much less than anyone would like. My grim suspicion is that either:

Option 1 seems likelier. In any case, a working alternative to both options would be for:

  1. Someone who is not me to upload these patches to a more reliable service than GoogleDrive. For reasons,blame google GoogleDrive links are not usable from automated scripts. The patches are too large to reasonably host at this repository. Moreover, attempting to do so given the content of several of the patches (ahem H ahem) would be a fantastic way to get this repository flagged and flogged by Microsoft. Let's please avoid that BAD END.
  2. Refactor our Lutris installer to:
    1. Automatically fetch all of these patches from that reliable service. Yes, this is silly. The Ultimate Installer already fetches all of these patches and I don't recall there being any way to automatically disable that behaviour at the command-line. ...or is there?
    2. Automatically overwrite all of the patches fetched and installed by the Ultimate Installer with the patches fetched by our Lutris script. Yes, it would be cleverer to attempt to detect for faulty patches with arcane and curmudgeonly Bash commands (e.g., some variant on find . -type f -size -4096c), but that would then require writing a full-blown Bash script that would then need to somehow conditionally invoke curl or wget on as as-needed basis, and I'm unsure that Lutris even allows that sort of dangerous shenanigans. For security, it probably shouldn't. In short, ain't nobody got that kinda time or sanity. ...or do they? I don't, but maybe you or someone else does! Please write me this script, somebody.

This is starting to look ugly and risky and I'm all out of bubblegum. Rather than actually doing anything, let's leave this issue open and see if anyone has any brighter ideas than my shameless rambling above.

leycec commented 4 years ago

Ahah! @gourrykun helpfully identified the culprit at #1:

Currently this step often fails due to disk quota exceeded.

Welp. It was Option 2 after all. </sigh>

On the bright side, this isn't our fault. On the dark side, the Ultimate Installer team at Beast's Lair now desperately needs to upload their patchset to a more reliable host. For reasons stated above, that can't be GitHub and shouldn't be GoogleDrive. If anyone who is not me would like to open up a discussion with our Beast's Lair sempais about this, that would be just great.

Until then, our hands are gently tied by Ilya.

leycec commented 4 years ago

Status update on repository inactivity with apologies. </sigh>

kaasknak commented 3 years ago

I am also running into the problem of patches not being downloaded and manual patches being unavailable due to google drive saying too many people downloaded it already. I am however not sure if that is the only issue since I am also using ubuntu 20.04 and as you mentioned here https://github.com/leycec/fsnrnue/issues/14#issuecomment-879578177 there could be a problem with that as well.

Would this be fixable or would it be best to hope for version 1.0 finally hitting? I even considered installing windows in a virtualbox (shudders). Would this be a better option?

leycec commented 3 years ago

...and manual patches being unavailable due to google drive saying too many people downloaded it already.

Yikes. I've long suspected this was infrequently happening. It's mildly depressing to learn this is now frequently happening and may even be the "new normal."

I am however not sure if that is the only issue...

Fortunately, that's the only outstanding issue I know of. Every other issue usually reduces to: "Your Vulkan, DXVK, and/or D3D9 drivers are broken. Please fix them."

So, you can at least be consoled (in the oppressive darkness of yet another filthy hot midsummer's evening with a busted air conditioner, a tap that only runs lukewarm, and five dogs that drape themselves across your prone body as you fitfully fail to sleep) that what you're seeing is almost certainly failing patches. :sob:

That's it. Admittedly, not even being able to download patches is a bit of a hard blocker.

Would this be a better option?

The best option would be for you to graciously do everyone in the Linux Fate/stay night community a heroic and painfully self-sacrificial favour. I wouldn't normally beg, I swear! But...

You seem like you're desperately keen. I can hardly blame you. Fate/stay night is one of the better and crazier things I've ever read – and I actually read books. Like, voluntarily.

So, here goes. When you find a spare moment, would you mind:

If you do decide to take one for the Linux team by posting, please avoid mentioning Linux. (See (B) above.) Pertinent questions might include:

...stuff like that. I haven't kept abreast of developments at The Beast's Lair. However unlikely, they might have already resolved some or all of the above issues. Let's choose to believe what I am saying so we can sleep at night.

kaasknak commented 3 years ago

I have tried signing up to the beast's lair. As you said indeed. It is an annoying process (there are fate related questions you have to answer but I am trying to get the patch so I can play it so I can answer the questions. Duckduckgo was my friend.). I have tried two different e-mail addresses and neither received the confirmation mail so I am going to hope it shows up later and I might have some time to check in again tomorrow (I am currently on vacation).

I'll keep you appraised.

kaasknak commented 3 years ago

Great news! I managed to acquire the patches. I still haven't received an e-mail from the beast's lair but there is a (shitty) mirror. https://www.mediafire.com/file/047tv8akannrti3/patch.zip/file this zipfile contains all the patches. Password of the zipfile is ObviouslyFate. After patching I only had to disable Vulkan (I got the white screen with audio) and it seems to work now. Cursor behaviour is a bit weird but that might be caused by many things. With this mirror available I think you can also close this issue. Just add the link to the README.md as a mirror and it should work.

You are an absolute legend by the way for writing a README that contains so many fixes for potential problems.

kaasknak commented 3 years ago

16 I took the liberty of sending a pull request that adds the mirror to the README.md

leycec commented 3 years ago

I still haven't received an e-mail from the beast's lair but there is a (shitty) mirror.

Indeed, this is Ilya-approved great news. No mirror can be shittier than Google Drive. That makes Mediafire the new only-working mirror and still-reigning champion! We now give thanks. Still, I kinda suspect this is what we were all hoping for:

mega.io: a new contender has emerged

After patching I only had to disable Vulkan (I got the white screen with audio) and it seems to work now.

Yay! Vulkan, y u so logical but never work right?

Cursor behaviour is a bit weird but that might be caused by many things.

Yes, the many things that are called WINE. Cursor desynchronization is still a common thing when running WINE-emulated apps under X.org; for reasons that were never clear to me, WINE was never able to get that right.

Running WINE-emulated apps under Wayland probably fixes that – but you can pry my decades-old X.org FVWM configuration from my cold, dead neckbeard hairs!

You are an absolute legend by the way for writing a README that contains so many fixes for potential problems.

ohyou :blush:

Thanks so much for your stupendous PR, by the way! That should go a long way to finally resolving everyone's main complaint with this whole thing.