search

leycec / raiagent

Third-party Gentoo overlay. Ride the Lagrangian point between awesomeness and volatile compounds.
31 stars 14 forks source link

Revert unneeded changes done to libvterm #28

Closed ZyX-I closed 9 years ago

ZyX-I commented 9 years ago

This library has absolutely nothing to do with X server. It only parses terminal keycodes, part of which happened to first appear in xterm in place of hardware terminals.

Also without src_install it installs to /usr/local. No other ebuild I have does this.

leycec commented 9 years ago

This library has absolutely nothing to do with X server.

With apologies, I disagree. libvterm appears to be comparable to libiterm, a "platform-independent framework for making Internationalized Virtual Terminal Emulator." Like libvterm, libiterm is independent of X11 but nonetheless officially categorized under x11-libs. (Of course, one might justifiably argue that this was a mistake.) Unlike libiterm, libvterm's tagline explicitly references xterm.

It seems pretty cut and dry. If this were ROTE, I'd be compelled to agree with you. ROTE is genuinely orthogonal to X11. But libvterm isn't.

leycec commented 9 years ago

Also without src_install it installs to /usr/local. No other ebuild I have does this.

You're absolutely right. That's terrible. That said, reenabling that bit of code provoked a Gentoo-specific fatal error on installation:

Files matching a file type that is not allowed:
   usr/lib/libvterm.so.0.0.0

After correcting this, libtool coughed up ignorable warnings in bright red (...I kid you not) resembling:

 libtool: warning: '/var/tmp/portage/x11-libs/libvterm-9999-r1/work/libvterm-9999/libvterm.la' has not been installed in '/usr/local/lib'
 libtool: warning: remember to run 'libtool --finish /usr/local/lib'

So, I corrected that as well and a few other minor issues (e.g., documentation installation) in commit bfba44c9a2249a277. Cheers, ZyX.

ZyX-I commented 9 years ago

You're absolutely right. That's terrible. That said, reenabling that bit of code provoked a Gentoo-specific fatal error on installation:

It is strange, because on my system it installs fine, except that I also saw libtool warnings (not Gentoo fatal errors): https://bpaste.net/show/7a7520033d10.

With apologies, I disagree. libvterm appears to be comparable to libiterm, a "platform-independent framework for making Internationalized Virtual Terminal Emulator." Like libvterm, libiterm is independent of X11 but nonetheless officially categorized under x11-libs. (Of course, one might justifiably argue that this was a mistake.) Unlike libiterm, libvterm's tagline explicitly references xterm.

Because xterm happened to become next generation standard after VT*. This is also why libiterm does not have to mention this: it would be expected for this kind of library unless stated otherwise.

According to the /usr/portage/x11-libs/metadata.xml this category is for “The x11-libs category contains various X11-related libraries.” I am wondering when xterm happened to become part of the Xorg project? Except for the rather indirect relation through a supported standard there is no relation to X11 in libvterm.

// By the way, there happen to exist two projects named libvterm: this one and the similar one, but based on ROTE.