ZyX-I
commented
9 years ago For reference: Ebuild Revisions: powerline ebuild already has too many version bumps which should not be there:
Important: For ebuilds marked stable on at least one arch, only trivial edits can be made without a bump (e.g. typo fixes in elog messages). Even simple changes may result in a breakage. Modifying stable ebuilds should be avoided.
is not applicable here (9999 is not marked stable) and
Ebuilds should have their -rX incremented whenever a change is made which will make a substantial difference to what gets installed by the package — by substantial, we generally mean "something for which many users would want to upgrade". This is usually for bugfixes. For any such revision bump, the new ebuild should be based on the previous revision to ensure that fixes aren't dropped accidentally.
Simple compile fixes do not warrant a revision bump; this is because they do not affect the installed package for users who already managed to compile it. Small documentation fixes are also usually not grounds for a new revision. In particular, this applies if the package has a substantial compilation time; developers should use their best judgement in these circumstances.
Last highlighted statement was broken a numerous times: actually there should only have been bumps for new USE flags, at maximum new USE flags and changes to README (including the one when it was created).
leycec
This should actually be part of the #29 should I mention it in time.
Did not rename ebuild file because the only thing this change does is removing ewarns what has the only effect of user not seeing two additional messages after build (so users have no reason to want powerline be reemerged automatically).