Closed ZyX-I closed 9 years ago
I hope that presence of libvterm-neovim in dev-libs in main portage tree puts an end to the discussion “what category this package should belong to”.
You win! I still disagree with that classification, but... I suppose it doesn't particularly matter. We'd better do this the Portage way before other ebuilds start depending on libvterm
.
Thanks for noticing the new libvterm-neovim
package, bringing this to my attention, and fixing this. As always, you're awesome.
O.K.!
Everything looks great except for the commit installing bot-ci
's license. Per the Gentoo development guide for the src_install()
phase function:
Note: There is no need to
dodoc COPYING
! The license belongs to${PORTDIR}/licenses
. Sometimes though, you might want to installCOPYING
regardless, if it explains how different licenses are applied to different parts of the application, for example.
Since bot-ci
only requires the vanilla MIT license, the latter clause doesn't really apply, implying its LICENSE
should not be installed. If you wouldn't mind removing that commit, I'd be happy to accept everything else without changes.
Removed commit that does LICENSE copying.
Superb. It's in!
Most notable is libvterm in dev-libs (maybe it makes sense to remove this package completely, though upstream does not do tests). I hope that presence of libvterm-neovim in dev-libs in main portage tree puts an end to the discussion “what category this package should belong to”.
libvterm-neovim mainly exists because you cannot disable stderr warning or debug messages in upstream libvterm and is rather compatible. Also contains some minor fixes AFAIK.