search

leycec / raiagent

Third-party Gentoo overlay. Ride the Lagrangian point between awesomeness and volatile compounds.
31 stars 14 forks source link

Cataclysm-dda: Patch to add USE_XDG_DIR option in 0.9c #44

Closed lucianposton closed 8 years ago

lucianposton commented 8 years ago

Fixes #43

The patch seems to work fine. I also added a warning when upgrading from the prior version in pkg_postinst().

The more I thought about it, the more I think you probably wouldn't want to modify the 0.9c behavior, but here's that patch anyway, in case you want to pull it.

leycec commented 8 years ago

The patch seems to work fine.

Yay! Thanks for this valuable fix.

The more I thought about it, the more I think you probably wouldn't want to modify the 0.9c behavior....

Yeah. I'm totally O.K. with butchering the default 0.9c behaviour, particularly as this is an official patch.

That said, I have two concerns which I'm happy to address myself:

  1. The patch should only be conditionally applied to 0.9c. The live ebuild should, of course, remain unpatched. Perhaps Portage simply ignores epatch() attempts when no such patch exists? If so, I'd still prefer that the patch be conditionally applied. EDIT: Ah, I see. You've de-linked the 0.9c-r3 and 9999 ebuilds. That certainly does work, but I'd prefer to maintain the symbolic link for now. I'll relink these ebuilds shortly. Null sweat, omae.
  2. A new xdg USE flag should be added, disabled by default. If disabled, the USE_HOME_DIR option should be passed to emake(); else, the USE_XDG_DIR option should be passed to emake(). I actually prefer USE_HOME_DIR myself, so I'm not quite sure why I coerced USE_XDG_DIR. <shrug/>

This is really all my fault, however. I'm happy to see to these changes myself. Thanks again, and may the zombie-infested highways of life be with you.

leycec commented 8 years ago

It is done.