Cataclysm build broken: new Makefile variable clashes with portage variable

leycec / raiagent

Third-party Gentoo overlay. Ride the Lagrangian point between awesomeness and volatile compounds.

31 stars 14 forks source link

Closed lucianposton closed 8 years ago

lucianposton commented 8 years ago

https://github.com/CleverRaven/Cataclysm-DDA/commit/376bb9a9e4a313b609a8c218b694f68ada883a23#diff-b67911656ef5d18c4ae36cb6741b7965 added BUILD_PREFIX to change the build dir. This just so happens to be an env variable used by portage ("/var/tmp/portage" by default). This causes some artifacts to appear in /var/tmp/, e.g. /var/tmp/portageobj for the obj dir.

The safest bet is probably to sed the cataclysm makefile to replace the variable name e.g. s/BUILD_PREFIX/CATACLYSM_BUILD_PREFIX/.

leycec commented 8 years ago

Urgh. Thanks for the observant catch – and even more observant suggestion, which I'm in full agreement with. ^{sed hackage for the win.}

I'll get this patched up over the next several days. :sunrise:

leycec commented 8 years ago

This should be fixed now. For maintenance, the C:DDA ebuild has also been improved to:

Thanks again, Lucian. (Nice avatar, too.)