leycec / raiagent

Third-party Gentoo overlay. Ride the Lagrangian point between awesomeness and volatile compounds.
32 stars 14 forks source link

media-sound/vgmplay doesn't compile when libao isn't installed #62

Closed ValleyBell closed 7 years ago

ValleyBell commented 7 years ago

It's actually my fault that it does this.
The Makefile enables libao by default unless you patch it. It also ignores the opl USE flag due to similar reasons.

You can use this patch to fix this

diff --git a/VGMPlay/Makefile b/VGMPlay/Makefile
index 520ab84..df78cd1 100644
--- a/VGMPlay/Makefile
+++ b/VGMPlay/Makefile
@@ -16,10 +16,10 @@
 #MACOSX = 1

 # disable Hardware OPL Support
-DISABLE_HWOPL_SUPPORT = 1
+#DISABLE_HWOPL_SUPPORT = 1

 # Uncomment if you want to use libao instead of OSS for sound streaming under Linux
-USE_LIBAO = 1
+#USE_LIBAO = 1

 # Uncomment for debug builds
 #DEBUG = 1

I'll fix this in the Git repo later. The patch will be required for all releases <= 0.40.8 though.

leycec commented 7 years ago

It's actually my fault that it does this.

It's... it's not actually my fault? I have never heard those joyous words before this fateful day.

You can use this patch to fix this...

Pure excellence. I appreciate the attention to detail. I'll probably refactor these two changes into sed-based regex replacements, because... obsessive-compulsive reasons with no bearing on tangible reality.

This shall happen soon. Maybe when I drop the 0.40.8 bomb? Tomorrow. Always tomorrow.

I'll fix this in the Git repo later. The patch will be required for all releases <= 0.40.8 though.

It is understood. Thanks again for the detailed report. We'll right this sinking ship yet! 🚢

leycec commented 7 years ago

Bam! Everything appears to behave as expected for 0.48.0 now. 🍾