search

leycec / raiagent

Third-party Gentoo overlay. Ride the Lagrangian point between awesomeness and volatile compounds.
31 stars 14 forks source link

Update Cataclysm:DDA Urls #71

Closed winny- closed 5 years ago

winny- commented 5 years ago

I did not test the revision bump + HOMEPAGE change in the ebuilds. I wish I knew how to do that without a great deal of effort :)

leycec commented 5 years ago

Awesome. By visual inspection (read: poorly informed post-hoc rationalization), this changeset looks great. Yet again, the C:DDA userbase shames me with superior intellect and excrutiating attention to detail.

Thanks, @winny-! Bother free is, indeed, the way to be. :bear: :honey_pot:

leycec commented 5 years ago

Oh, and please note for future submissions that the Portage convention is to only bump ebuild revision numbers on significant internal improvements. Since URL redirects aren't necessarily significant (with respect to ebuild behaviour, anyway), this pull request probably shouldn't have bumped ebuild revisions.

That said, this is a subjective grey area – and I was planning on bumping ebuild revisions anyway after resolving #69. So, this wouldn't be the worst thing that's happened to me today. That would be my receding hairline, which clever comb overs now fail to hide. ...middle-age problems.

winny- commented 5 years ago

Super! Thank you for the feedback - I follow what you mean with the version bump - especially for metadata changes that don't affect the contents.

I aspire to test every ebuild change I make, but somehow testing system packages is often surprisingly nontrivial. Thanks again for bearing with my only-visually-inspected PR. Interesting essay - thanks!