search

leylaso / django-etherpad-lite

Project to provide a django based UI for etherpad lite
33 stars 11 forks source link

Django 1.5 compatibility #20

Open codingisacopingstrategy opened 11 years ago

codingisacopingstrategy commented 11 years ago

Hello,

Trying to run this with Django 1.5 it fails to start the development server with the TypeError: __init__() got an unexpected keyword argument 'verify_exists'. I guess that’s because this functionality is removed from this version:

django.db.models.fields.URLField.verify_exists will be removed. The feature was deprecated in 1.3.1 due to intractable security and performance issues and will follow a slightly accelerated deprecation timeframe.

https://docs.djangoproject.com/en/1.5/internals/deprecation/#id2

codingisacopingstrategy commented 11 years ago

The culprit is https://github.com/sfyn/django-etherpad-lite/blob/master/etherpadlite/models.py#L17

Simply removing it works under Django 1.5, however that has the side effect of re-enabling verify_exists under 1.4 and 1.3.

See https://github.com/stefanfoulis/cmsplugin-filer/pull/78 for a multi-version workaround

best,