search

lf- / lti13

A Haskell LTI 1.3 library
GNU Lesser General Public License v3.0
4 stars 1 forks source link

support aeson >= 2 #4

Closed kisonecat closed 2 years ago

kisonecat commented 2 years ago

I'd like to be able to use li13 with aeson >= 2.

To make this possible, I replaced some Text with Aeson.Key in a few places in a80b1e0b24c19cc4304306d13acf3366eacdb81a which seems necessary to provide compatibility with aeson >= 2. I imagine there are cleaner ways of handling this.

In any case, I wasn't able to get yesod-auth-lti13 to work with these changes, hence my opening an issue rather than submitting a PR.

lf- commented 2 years ago

I'll look into this when I have time. Thanks for the pointers!

lf- commented 2 years ago

Gosh, sorry it took so long. I'm going to fix this this evening.

kisonecat commented 2 years ago

Oh no need to apologize -- I just am very appreciative of your having put this whole thing together!

lf- commented 2 years ago

Hi! I've made a pull request and from testing it against the LTI reference implementation I believe it to work. Can you check if it works for you?

lf- commented 2 years ago

Closed and 0.3.0.0 of both lti13 and yesod-auth-lti13 have been published. Let me know if you have any issues!

kisonecat commented 1 year ago

This is working great -- thank you so much!