search

lf-edge / eden

Eden is where EVE and Adam get tried and tested:
https://projecteve.dev
Apache License 2.0
49 stars 47 forks source link

GitHub Actions: Bump reusable actions to be compatible with node16 #1000

Closed uncleDecart closed 1 month ago

uncleDecart commented 1 month ago

Following actions were using node12 which is deprecated and they were forced to use node16. Also upload-release-asset was deprecated so this patch switches to maintained action listed in official repository

uncleDecart commented 1 month ago

cc @yash-zededa for some reason I can't add you to reviewers

uncleDecart commented 1 month ago

I believe this is the reason why this workflow broke https://github.com/lf-edge/eden/actions/runs/9829563875 (last week I released eden 0.9.10)

yash-zededa commented 1 month ago

cc @yash-zededa for some reason I can't add you to reviewers

I can't add my review. It looks like I need to be a collaborator for the Eden repo. @uncleDecart, do you have access to add me as a collaborator?

uncleDecart commented 1 month ago

I have no power here, we have to ask @deitch or @eriknordmark for that

giggsoff commented 1 month ago

I can see that GH expect new versions for another actions as well (here in annotations):

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-go@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Do you plan to update them separately?

uncleDecart commented 1 month ago

Yes @giggsoff , I'll do them separately :)